-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate project to (only) Go modules #12
Migrate project to (only) Go modules #12
Conversation
@@ -12,7 +12,6 @@ script: | |||
- GOOS=linux GOARCH=amd64 go build -ldflags="-X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildVersion=$VERSION' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildTime=$time' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit=$TRAVIS_COMMIT'" -o nancy-linux.amd64-$VERSION | |||
- GOOS=darwin GOARCH=amd64 go build -ldflags="-X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildVersion=$VERSION' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildTime=$time' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit=$TRAVIS_COMMIT'" -o nancy-darwin.amd64-$VERSION | |||
- GOOS=windows GOARCH=amd64 go build -ldflags="-X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildVersion=$VERSION' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildTime=$time' -X 'github.com/sonatype-nexus-community/nancy/buildversion.BuildCommit=$TRAVIS_COMMIT'" -o nancy-windows.amd64-$VERSION.exe | |||
- ./nancy-linux.amd64-$VERSION Gopkg.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should still stick around as we still support dep from a nancy standpoint and this is effectively an "integration test". Maybe just move that file into a directory and point this to it.
@@ -61,11 +58,18 @@ Each commit to master creates a new release binary, and if you'd like to skip bu | |||
|
|||
## Development | |||
|
|||
`nancy` is written using Golang 1.11, so it is best you start there. | |||
`nancy` is built with Go 1.11 and supports Go modules. The easiest way to get started is to clone Nancy into a directory outside of the `$GOPATH`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and Build from source
are basically identical do we really need both??
I'm all for this! I was asking for it in #22, and I'd love to see it 😄 |
Closing this PR as #67 took care of this already |
Go Modules is the standard moving forward. This PR removes
dep
from the project and fully migrates to Go modules.I've also updated the Readme, removing
dep
references and tried to clean up the install section a bit.